Test collab changes #4041
Test collab changes #4041
Conversation
| build: https://github.com/sugarlabs/musicblocks.git#collaboration | ||
| # build: https://github.com/sugarlabs/musicblocks.git#test-collab | ||
| build: | ||
| context: ./ |
There was a problem hiding this comment.
Seems this was needed for a test, the idea here is to build from this repo and not local sources.
There was a problem hiding this comment.
Yeah, I tried this lots of time but it was not building the image from the remote repo (my network can be the reason, I'll try again). Just for testing purpose, I tried to build using the local repo as it contains the same code.
There was a problem hiding this comment.
It's probably an issue with your network, did you try again and did it work?
If it's your network then you can do this locally without committing it.
| MYSQL_ROOT_PASSWORD: root | ||
| MYSQL_DATABASE: planet | ||
| volumes: | ||
| - /Users/ajeetpratapsingh/Developer/os/planet-server/planet.sql |
There was a problem hiding this comment.
It'll be great if you don't hard code values like this because if I was testing, I wouldn't have that directory and that'll break things.
There was a problem hiding this comment.
I have created a local db planet-mysql for testing purpose and I assume, we will also have a db on our remote server to reference a volume like this and this path /Users/ajeetpratapsingh/Developer/os/planet-server/planet.sql will be changed to server's local path. is there any better way to add volume, like fetching from somewhere?
There was a problem hiding this comment.
You could just reference a volume with it's name and it'll automatically be created if it doesn't exist, no need for a path to an existing volume.
If you want to mount a db that's part of the repo in the container, then that's something you can still do.
This PR make changes to run all the services using a single docker-compose file