Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: widgets/help - lint, prettify and documentation #2768

Merged
merged 4 commits into from
Jan 25, 2021

Conversation

ksraj123
Copy link
Member

Reference #2609, #2630, #2767

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   28:7   warning  'HelpWidget' is defined but never used  no-unused-vars
  315:40  error    'blocks' is not defined                 no-undef

 2 problems (1 error, 1 warning)

2nd one is an easy fix. But, the first one requires /* exported HelpWidget */ which somehow doesn't seem to work with babel-eslint. Can you find a solution?

@ksraj123
Copy link
Member Author

ksraj123 commented Jan 24, 2021

@meganindya /* exported */ does not work when sourceType is modules or when globalReturn is enabled (documented here). After making the necessary changes to .eslintrc.json it seems work fine. Thanks

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@meganindya meganindya merged commit a915dd5 into sugarlabs:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants