Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Pitch piemenu do not remember the last selected accidental value #4070

Open
omsuneri opened this issue Nov 21, 2024 · 2 comments
Open

The Pitch piemenu do not remember the last selected accidental value #4070

omsuneri opened this issue Nov 21, 2024 · 2 comments

Comments

@omsuneri
Copy link
Contributor

omsuneri commented Nov 21, 2024

Description

The thing is the pitch piemenu must remember all the custom accidental, note and octave but in this issue the pitch piemenu is unable to remember the custom accidental selected and always directs to the default value which is kind of a bad experience.

Expected Behavior

the Pitch piemenu must remeber the last selected accidental value too as it does with the note and octave value in the wheel

Screenshots

custom pitch selected
Screenshot 2024-11-22 at 1 46 21 AM
the wheel do not represents the same vaue as
Screenshot 2024-11-22 at 1 46 44 AM

How to Reproduce

try changing the value and you can observe the change

Console log Errors:

N/A

Environment:

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Checklist

  • [y] I have read and followed the project's code of conduct.
  • [y] I have searched for similar issues before creating this one.
  • [y] I have provided all the necessary information to understand and reproduce the issue.
  • [y] I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@omsuneri
Copy link
Contributor Author

@walterbender check the PR for this issue

@omsuneri
Copy link
Contributor Author

@walterbender PR updated see the changes #4071 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant