-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4063 Canvas is scrolling on drag and select #4064
base: master
Are you sure you want to change the base?
Fixes #4063 Canvas is scrolling on drag and select #4064
Conversation
Works great but you can no longer scroll by dragging the canvas. Not sure what the solution is. Maybe right-mouse button to select? Or long press and drag to select? @pikurasa any suggestions? |
@walterbender I think scrolling canvas by dragging was never possible in MB, it can be scrolled with the help of arrow keys. |
@walterbender @pikurasa I think we should add a new feature in which we can use:
What do you think, should I work on it. |
We also use long press as a way to indicate right-click on devices w/o buttons (or only single buttons). |
@walterbender ok I'll work on it. |
I don't think it is prudent to merge as is since scrolling the block container is pretty fundamental whereas select is not. |
Ok I'll update my changes in this PR only. |
@walterbender I have updated my changes to:
Vedio: scroll-and-select.mp4Please review. |
It is working for me except that when I right-click, I also get the right-click menu. I can still select the region, but it is not a very good UX. |
Also, we need to test on some touch devices. |
I tested and I didn't get right-click menu when I did right click and drag on canvas to select, right click pie menu open only when we do right click on a block (I think that's fundamental). |
I have been testing with Firefox on Fedora. Now I cannot get right click to select. Not sure why. I'll test on Chroma as well. |
Previously I was testing it by launching from pie-issue.mp4you can see I tried reproducing it but It didn't show up. @walterbender could you please tell me which of the changes I made could have caused this? or is this issue existed before my changes? |
I tested on chrome with the local server too. Same problem. Question: Are you in advanced mode? The right-click menu only shows up in advanced mode. Also, it would be nice to treat long press as right click too. |
Maybe a solution might be to add select to the right-hand menu instead of invoking it directly from right click and drag? |
@walterbender yes I was in beginner mode that's why it was not showing. |
@walterbender sounds good, I'll try to implement it. |
Fixes #4063 this issue arises after the commit b5be318 I have made the required changes to it fix this issue.
@walterbender please review.
Vedio:
fix-scroll.on.select.mp4