Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyric input via Phrase Maker #3842

Open
pikurasa opened this issue Mar 28, 2024 · 7 comments
Open

Lyric input via Phrase Maker #3842

pikurasa opened this issue Mar 28, 2024 · 7 comments
Labels

Comments

@pikurasa
Copy link
Collaborator

Current Behavior

Right now, if the user wants lyrics, they need to manually put the lyrics in, one by one, into note blocks.

The end result looks like this:

Screenshot from 2024-03-28 14-37-26

Desired Behavior

Perhaps we add a feature to Phrase Maker to input lyrics, initiated by placing a print block into the widget stack.

You would type the lyrics into a new row at the bottom of Phrase Maker called "Lyrics".

Screenshots / Mockups

Print block inside widget stack:

Screenshot from 2024-03-28 14-52-07

Implementation

  • Insert print block into Phrase Maker widget stack
  • Initiate Phrase Maker widget
  • Phrase Maker with "Lyrics" row is generated
  • Click a cell in the lyrics row
  • type your lyric fragment into a simple prompt
  • press TAB to go to the next cell in row, or click return/enter or somewhere else to exit and save
  • any notes with lyric fragments indicated in Phrase Maker will be generated with a print block with the text of that fragment
@therealharshit
Copy link
Contributor

@pikurasa is this fine or you want print block somewhere in between the widget stack?

Vedio:

2024-08-26-01-16-25.mp4

therealharshit added a commit to therealharshit/musicblocks that referenced this issue Sep 27, 2024
@therealharshit
Copy link
Contributor

I have made the changes and raised a PR #4016 please review.

@omsuneri
Copy link
Contributor

Is it still open @pikurasa

@therealharshit
Copy link
Contributor

Is it still open @pikurasa

@omsuneri I am working on it, and I have raised a draft PR for that.

@omsuneri
Copy link
Contributor

@therealharshit I m trying to observe the working and trying to resolve so shall I start contributing to this or should try any other issue

@therealharshit
Copy link
Contributor

@omsuneri in my PR only processing print block in phrase maker is left, I am figuring out that. If you want you can contribute.

@omsuneri
Copy link
Contributor

@therealharshit I ll continue this to complete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants