Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed functionality of middle-clicking and visual modifications to homepage #123

Closed
wants to merge 3 commits into from
Closed

Conversation

Dimi20cen
Copy link
Contributor

@Dimi20cen Dimi20cen commented Mar 27, 2023

Is this pull request structure okay? Would it be better if I made 3 different pull requests instead of one?

Changed browser.py

Changed data/index.html,

  • The menu on the top-right of the home screen now looks a bit smoother. Fixed the search box, previously the outline was incomplete at the corners. Search entry box looks odd #115.
    Note: I saw the discussion that keeping the search-box round is important. However index.html is not very readable, at least for me ( i dont really do html/css/js ) so I can't find the reason that makes the search-box so "stubborn". If you think it's a good idea, I'm open to rewrite the code for the index file from the ground up, that might be more fun.

if you want any different changes let me know.

@quozl
Copy link
Contributor

quozl commented Mar 27, 2023

Thanks. I've taken 1e6a897 as a468970 as it was uncontentious, though I rewrote the commit message.

The other two commits don't meet our standards. See Making commits for a checklist. Missing was explanation of problem. Everything you want to say should be in the commit message, there should be nothing in the pull request unless it does not need to be retained in git history. Pull requests are not kept, only commits are kept. Thanks!

@Dimi20cen Dimi20cen closed this Mar 27, 2023
@quozl
Copy link
Contributor

quozl commented Mar 27, 2023

Please change the commits in a pull request rather than close a pull request and open a new one. There was no technical reason to close this pull request. At the very least, a link to the new pull request would have been helpful; #124

@Dimi20cen
Copy link
Contributor Author

Will do that next time, I got more confused than necessary with the git commit --amend, sorry and thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants