This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
[FEATURE]: Configure CryptoKeyReader in FlinkPulsarSource and FlinkPulsarSink
#386
Assignees
Labels
Comments
objecttrouve
changed the title
CryptoKeyReader in FlinkPulsarSource and a FlinkPulsarSinkCryptoKeyReader in FlinkPulsarSource and FlinkPulsarSink
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Aug 8, 2021
As requested [here](streamnative#386), it's now possible to pass a `CryptoKeyReader` (and encryption keys) to `FlinkPulsarSource` and `FlinkPulsarSink`. Used builder pattern for easy extensibility without breaking or excessively overloading public c'tors. Added integration test. (Maybe it can be moved to one of the other tests to avoid overhead.)
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Aug 8, 2021
As requested [here](streamnative#386), it's now possible to pass a `CryptoKeyReader` (and encryption keys) to `FlinkPulsarSource` and `FlinkPulsarSink`. Used builder pattern for easy extensibility without breaking or excessively overloading public c'tors. Added integration test. (Maybe it can be moved to one of the other tests to avoid overhead.)
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Aug 8, 2021
As requested [here](streamnative#386), it's now possible to pass a `CryptoKeyReader` (and encryption keys) to `FlinkPulsarSource` and `FlinkPulsarSink`. Used builder pattern for easy extensibility without breaking or excessively overloading public c'tors. Added integration test. (Maybe it can be moved to one of the other tests to avoid overhead.)
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Aug 8, 2021
As requested [here](streamnative#386), it's now possible to pass a `CryptoKeyReader` (and encryption keys) to `FlinkPulsarSource` and `FlinkPulsarSink`. Used builder pattern for easy extensibility without breaking or excessively overloading public c'tors. Added integration test. (Maybe it can be moved to one of the other tests to avoid overhead.)
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Sep 15, 2021
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Sep 15, 2021
Turned out builder pattern wasn't necessary here. There's one path now for the CryptoKeyReader (plus the encryption keys) and possibly others where it's null (and the keys are empty).
objecttrouve
added a commit
to objecttrouve/pulsar-flink
that referenced
this issue
Sep 15, 2021
|
i have the same issue. is there any plan to configure cryptokeyreader? |
|
@luigidalmare, there's a PR about to be merged. |
|
@objecttrouve Sorry for the late response. I still want to drop the |
|
@syhily, please modify as you please. Thanks for picking it up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
I want to configure a
CryptoKeyReaderwith both aFlinkPulsarSourceand aFlinkPulsarSink. I found that this isn't possible just by making settings in thePropertiesparameter (see also #11562 in the apache/pulsar project).Describe the solution you'd like
Possibility to pass an instance of
CryptoKeyReaderas an argument to the construction ofFlinkPulsarSourceandFlinkPulsarSink.Describe alternatives you've considered
Specify a class name in the properties and do a PR in the pulsar project that instantiates it. However, in most cases you'll want to configure the
CryptoKeyReaderand a no-arg instance would be useless. So it's not a good idea.Additional context
Also asked about it on Slack.
The text was updated successfully, but these errors were encountered: