Fix resolveNestedRelations disabling during StoryblokClient init

[edvinasjurele]

Expected Behavior

Storyblok client is possible to initialize with resolveNestedRelations disabled.

Current Behavior

Initializing the Storyblok client with resolveNestedRelations flag disabled, does not correctly set the initial value

const Storyblok = new StoryblokClient({
  accessToken: '<TOKEN>',
  resolveNestedRelations: false,
});

Temporary workaround

Manually set flag AFTER the storyblok client initialization.

Storyblok.resolveNestedRelations = false;

Steps to Reproduce

https://runkit.com/embed/xx23fbgocz7c

Potential defect

When passing resolveNestedRelations: false, as part of init object, the resolveNestedRelations should be set to false, but due to this.resolveNestedRelations = config.resolveNestedRelations || true in the

storyblok-js-client/src/index.ts

Line 150 in d04da2e

this.resolveNestedRelations = config.resolveNestedRelations || true

it is set to true for all falsey values including FALSE itself, as "false || true => true".

We might replace || with ??

[alvarosabu]

Hi @edvinasjurele thanks for opening this issue. I think I understand the issue, I tried to open the reproduction tho and it's broken (gives me an error) could you please add a working reproduction please?

[edvinasjurele]

Hi @alvarosabu, hm, the repro link works fine for me 🤔 but here is another repro: https://stackblitz.com/edit/stackblitz-starters-5wkmv5?file=index.js

[alvarosabu]

Hi @edvinasjurele thanks for providing another reproduction, I dont know what happened but I also managed to run the first one, I like the runkit is really helpful.

Let me take care of it.