Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to completely disable request throttling #816

Open
mvantellingen opened this issue Apr 29, 2024 · 2 comments
Open

Add ability to completely disable request throttling #816

mvantellingen opened this issue Apr 29, 2024 · 2 comments
Labels
e1-low [Effort] Low hanging fruit 🥭. feature [Issue] New feature or request p2-nice-to-have [Priority] Lower priority, beneficial enhancements that are not urgent.

Comments

@mvantellingen
Copy link

When using the storyblok-js-client in a server environment with a bit of traffic the storyblok-js-client causes significant slow downs due to request throttling. It should be possible to completely disable request throttling for performance (so not only changing the rateLimit setting).

For now we have created a fork which removes this functionality, see https://www.npmjs.com/package/@labdigital/storyblok-js-client but I would love to help get this option into the official client.

Note that while debugging the performance issue it also seems that the client creates quite some number of promises for requests, which also has impact on performance.

@rickvandermey
Copy link

It does have a huge performance improvement! However when we try the fork, it doesn't render anything on the server anymore. Something to keep in mind

@alvarosabu alvarosabu added pending-triage [Issue] Ticket is pending to be prioritised feature [Issue] New feature or request labels Aug 21, 2024
@alvarosabu
Copy link
Contributor

Hi @mvantellingen thanks for the feat request. Let me bring it up internally and keep you updated.

@alvarosabu alvarosabu added e1-low [Effort] Low hanging fruit 🥭. p2-nice-to-have [Priority] Lower priority, beneficial enhancements that are not urgent. and removed pending-triage [Issue] Ticket is pending to be prioritised labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e1-low [Effort] Low hanging fruit 🥭. feature [Issue] New feature or request p2-nice-to-have [Priority] Lower priority, beneficial enhancements that are not urgent.
Projects
None yet
Development

No branches or pull requests

3 participants