Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra div added at the root doc level #146

Open
alexjoverm opened this issue Nov 18, 2024 · 0 comments · May be fixed by #148
Open

Extra div added at the root doc level #146

alexjoverm opened this issue Nov 18, 2024 · 0 comments · May be fixed by #148
Assignees
@alexjoverm
Labels
breaking-change Changes that cause backward compatibility issues and will require a major version. bug Something isn't working p3-significant [Priority] Moderate issues, major enhancements

Comments

@alexjoverm
Copy link

alexjoverm commented Nov 18, 2024 •
edited
Loading

In storyblok-js-client, render rich text didn't add an extra div at the root level when rendering the doc. But @storyblok/richtext does. This can impact on layouts and stylesheets already existing.

This suppose a breaking change when moving from js-client to storyblok/richtext.

Expected Behavior

Not to have a wrapper div

Current Behavior

There is an extra wrapper div

Steps to Reproduce

Go to this stackblitz, and see both options running with their differences https://stackblitz.com/edit/richtext-extra-div?file=main.js
@alexjoverm alexjoverm self-assigned this Nov 18, 2024
@alexjoverm alexjoverm added bug Something isn't working breaking-change Changes that cause backward compatibility issues and will require a major version. p3-significant [Priority] Moderate issues, major enhancements labels Nov 18, 2024
@alexjoverm alexjoverm linked a pull request Nov 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjoverm alexjoverm

Labels
breaking-change Changes that cause backward compatibility issues and will require a major version. bug Something isn't working p3-significant [Priority] Moderate issues, major enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid rendering extra div on doc storyblok/richtext
1 participant
@alexjoverm