Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add "Unknown exception" to retryable mixin #2

Open
3 tasks
inertia186 opened this issue Jun 28, 2018 · 1 comment
Open
3 tasks

Need to add "Unknown exception" to retryable mixin #2

inertia186 opened this issue Jun 28, 2018 · 1 comment

Comments

@inertia186
Copy link
Contributor

BaseError needs to handle Unknown exception in addition to the others.

Note, hivemind is moving away from a whitelist due to maintenance concerns.

AC

  • lib/steem/base_error.rb handles Unknown exception as Steem::UnknownException, similar to the other three mentioned in retry all errors hivemind#126 (comment)
  • lib/steem/mixins/retriable.rb is updated to include Steem::UnknownException in RETRYABLE_EXCEPTIONS
  • lib/steem/rpc/http_client.rb might also include these or a subset.
inertia186 added a commit that referenced this issue Oct 3, 2018
@inertia186
Copy link
Contributor Author

This whole thing is a bit of a facepalm because the upstream (jussi or something) might respond with ambiguous errors, handled by accurately named error classes.

But which one's which?

I just wanted to clarify, the commit references Steem::UnknownExceptionError but the issue references Steem::UnknownException. The actual error is indeed intended to be Steem::UnknownExceptionError.

The true error is Steem::UnknownExceptionError because it whitelists the error message "Unknown Exception" from upstream. Getting the text "Unknown Exception" from the upstream API is a different situation from getting a new error message that steem-ruby has never encountered before (aka: Steem::UnknownError).

The rule is simple:

  • Doesn't exist, it was just a typo in the original issue: Steem::UnknownException
  • Should probably retry: Steem::UnknownExceptionError
  • Should never retry: Steem::UnknownError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant