You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BaseError needs to handle Unknown exception in addition to the others.
Note, hivemind is moving away from a whitelist due to maintenance concerns.
AC
lib/steem/base_error.rb handles Unknown exception as Steem::UnknownException, similar to the other three mentioned in retry all errors hivemind#126 (comment)
lib/steem/mixins/retriable.rb is updated to include Steem::UnknownException in RETRYABLE_EXCEPTIONS
lib/steem/rpc/http_client.rb might also include these or a subset.
The text was updated successfully, but these errors were encountered:
This whole thing is a bit of a facepalm because the upstream (jussi or something) might respond with ambiguous errors, handled by accurately named error classes.
But which one's which?
I just wanted to clarify, the commit references Steem::UnknownExceptionError but the issue references Steem::UnknownException. The actual error is indeed intended to be Steem::UnknownExceptionError.
The true error is Steem::UnknownExceptionError because it whitelists the error message "Unknown Exception" from upstream. Getting the text "Unknown Exception" from the upstream API is a different situation from getting a new error message that steem-ruby has never encountered before (aka: Steem::UnknownError).
The rule is simple:
Doesn't exist, it was just a typo in the original issue: Steem::UnknownException
Should probably retry: Steem::UnknownExceptionError
BaseError
needs to handleUnknown exception
in addition to the others.Note, hivemind is moving away from a whitelist due to maintenance concerns.
AC
lib/steem/base_error.rb
handlesUnknown exception
asSteem::UnknownException
, similar to the other three mentioned in retry all errors hivemind#126 (comment)lib/steem/mixins/retriable.rb
is updated to includeSteem::UnknownException
inRETRYABLE_EXCEPTIONS
lib/steem/rpc/http_client.rb
might also include these or a subset.The text was updated successfully, but these errors were encountered: