New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triggers `BareExcept` warnings en masse #365

Open

tersec opened this issue Feb 24, 2023 · 0 comments

Contributor

tersec commented Feb 24, 2023

status-im/nimbus-eth2#4661

nimbus-eth2/vendor/nim-chronos/chronos/asyncfutures2.nim(389, 3) Warning: catch a more precise Exception deriving from CatchableError or Defect. [BareExcept]

nim-chronos/chronos/asyncfutures2.nim

Lines 389 to 393 in f7835a1

    
           except Exception as exc: 
        
             if exc of Defect: 
        
               raise (ref Defect)(exc) 
        
             fut.fail((ref ValueError)(msg: exc.msg, parent: exc))

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment