feat(modifyFieldsOnValue): enable field to modify itself #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-76687
PR Type
What kind of change does this PR introduce?
Summary
Changes
Remove verification to block field from applying modification to itself after value change.
It is not a risk to allow users to modify field itself as we should be concerned only for value. (it is still not a problem but seems like a bad approach to solving problems).
It also enables circular dependencies in case where modifications are not about value. (modifying values still should work good but seems like a bad practise)
User experience
User can right now modify state of field by applying changes to currently edited field, it allows to create ie. much more useful labels and help messages referencing value change.
Checklist
If an item doesn't apply to your changes, leave it unchecked.