Schema with comments for documentation not supported

[texascloud]

Assume the following schema is in a file named example.graphql

type Query {
    animals: [Animal]
}

type Animal {
    id: ID!
    "Scientific name of the Animal"
    name: String!
    "Hunting status of the Animal"
    status: Status!
}

"Indicates whether the animal can be hunted"
enum Status {
    pending
    available
}

Uploading it is successful, but no resolvermap gets created for it. It's due to the comments not being able to be parsed. However GraphQL Playground has support for showing these strings as documentation for the schema.

~/scratch/qloo » qlooctl schema create -f ./example.graphql animal
schema created successfully
------------------------------------------------------------
~/scratch/qloo » qlooctl schema get animal -o yaml
inline_schema: |
  type Query {
      animals: [Animal]
  }

  type Animal {
      id: ID!
      "Scientific name of the Animal"
      name: String!
      "Hunting status of the Animal"
      status: Status!
  }

  "Indicates whether the animal can be hunted"
  enum Status {
      pending
      available
  }
metadata:
  namespace: gloo-system
  resource_version: "2356965"
name: animal
status:
  reason: 'failed to parse schema: graphql: syntax error: unexpected "\"Scientific
    name of the Animal\"", expecting Ident (line 7, column 5)'
  state: Rejected

[ilackarms]

ahh, this makes sense. will need some time to look into a fix for this, feel free to bump this issue if it doesn't get attention in the next week or so.

also, we'd happily accept a pull request to help us add support for comments.

[texascloud]

Could you point me to where the parser logic is for consuming the schema?

[ilackarms]

https://github.com/solo-io/qloo/blob/master/pkg/core/event_loop.go#L232

the schema parsing is delegated to https://github.com/vektah/gqlgen
i'm surprised that library doesn't support comments. we might just need to do a dep ensure -v -update ...
or open an issue there ^_^

[deorbit]

It looks like this was fixed: 99designs/gqlgen#86 (comment). Are you able to update the gqlgen dependency?

[simenandre]

Bump :)

[fresonn]

Any updates? Still doesn't work