Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snake case from metrics names in snapshot templates #516

Open
elcasteel opened this issue Aug 25, 2022 · 1 comment
Open

Remove snake case from metrics names in snapshot templates #516

elcasteel opened this issue Aug 25, 2022 · 1 comment

Comments

@elcasteel
Copy link
Contributor

elcasteel commented Aug 25, 2022

We tried to use snake case for metrics names (

{{ $emitter_prefix := (print (snake .Name) "/emitter") }}
) but a bug in http://github.com/iancoleman/strcase meant that the names were rendered with dots anyway. A newer version of that library fixes the bug and if we update it, the metrics names change.

At this point, our users all have dashboards based on metrics names with dots and we should keep that convention.

@elcasteel
Copy link
Contributor Author

a complication is that solo-projects has already pulled in the updated version of the library and now has some files with snake case: https://github.com/solo-io/solo-projects/blob/master/projects/observability/pkg/api/v1/dashboards_snapshot_emitter.sk.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant