Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate code for caches #237

Open
ilackarms opened this issue Aug 6, 2019 · 1 comment
Open

generate code for caches #237

ilackarms opened this issue Aug 6, 2019 · 1 comment

Comments

@ilackarms
Copy link
Member

currently we have a lot of duplicated (kubernetes) caching code across our projects.

ideally we should be able to generate these as they are mostly copy-paste of each other

examples:

https://github.com/solo-io/solo-kit/blob/master/pkg/api/v1/clients/kube/cache/cache.go
https://github.com/solo-io/gloo/blob/master/projects/knative/pkg/api/custom/knative/cache.go
https://github.com/solo-io/gloo/blob/master/projects/clusteringress/pkg/api/custom/knative/cache.go
https://github.com/solo-io/supergloo/blob/master/pkg/api/custom/clients/smi/cache.go
https://github.com/solo-io/supergloo/blob/master/pkg/api/custom/clients/linkerd/cache.go

the generation need not be done by solo-kit itself. this problem is (currently) kubernetes-related and does not deal with solo-kit resources. however, these caches are consumed by solo-kit clients, so it may make sense to handle as part of solo-kit itslef

@ilackarms
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant