Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert the way List filter function behaves #170

Open
jenshu opened this issue Oct 23, 2020 · 0 comments
Open

invert the way List filter function behaves #170

jenshu opened this issue Oct 23, 2020 · 0 comments

Comments

@jenshu
Copy link
Contributor

jenshu commented Oct 23, 2020

Currently in the *Set interfaces, you can pass in a filter function to the List. The way it currently works is that when the filter function returns true, the item is excluded from the list. Conventionally, a filter function should return true to include the item in the results, and false to exclude it.

We should consider changing how all the List filter functions are implemented, or possibly rename the function to something less confusing. If we make this change, we should do it across all our repos to be consistent (for example, SMH also defines some interfaces with a List function).

This would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant