Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocsGen failing with NPE #496

Closed
bewebi opened this issue Aug 4, 2022 · 1 comment
Closed

DocsGen failing with NPE #496

bewebi opened this issue Aug 4, 2022 · 1 comment
Assignees

Comments

@bewebi
Copy link
Contributor

bewebi commented Aug 4, 2022

The Docs action for Gloo has been failing due to a nil pointer dereference repeatedly, for example here and here

I have been unable to reproduce this locally or identify a bug through static code analysis

Until the bug is reproduced/identified we can return an error in this case rather than panic in order to better understand the failing behavior when it occurs

@bewebi
Copy link
Contributor Author

bewebi commented Aug 18, 2022

This issue has arisen once since the fix was merged to error instead of panic

In that case the logged error was:

2022/08/10 14:02:28 unable to run: no release found for version ***Major:1 Minor:2 Patch:0 Label: LabelVersion:0***

(link)

It seems plausible, perhaps even likely, that the behavior will not occur once we stop processing exceedingly old versions which may have inconsistencies with regards to their ChangelogNotes.

This issue being closed since this particular failure seems to occur infrequently, including relative to other failures on the Docs action, and because a potential solution is scoped in another issue (#499)

Should the error recur after we stop processing older versions the issue should be reopened

@bewebi bewebi closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant