Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map old cookie value to the new cookie #312

Open
marcin-j opened this issue Jun 29, 2023 · 2 comments
Open

Map old cookie value to the new cookie #312

marcin-j opened this issue Jun 29, 2023 · 2 comments

Comments

@marcin-j
Copy link

Hi team,

I've opened this topic on Snowplow discourse. I did some digging, and it seems like it's not possible to do that easily with the current collector.

I've written a small update to the collector code to take the oldCookieName into consideration while mapping the old value to the new cookie name.

I'm not really efficient in Scala so hopefully, you can help me out with making this better :) The first thing would be to point me to someplace where I could add some unit tests I guess.

cheers :)

marcin-j added a commit to marcin-j/stream-collector that referenced this issue Jun 29, 2023
@marcin-j
Copy link
Author

Hey,

I still think this could be a valid feature, as a response that I got here would always require us to later map those two domain user ids in database - either rewrite them, for example, after a year, when the cookie expires; or map them continuously.

@marcin-j
Copy link
Author

marcin-j commented Dec 1, 2023

Hi guys,

I forgot about this issue, but it would be great to get some feedback from you because I'm still interested in merging this.

Is there any chance of getting this feature merged, or should this PR just be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant