-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logging of thread pool creation out of KinesisSink #129
Milestone
Comments
Merged
|
istreeter
added a commit
that referenced
this issue
Dec 4, 2021
istreeter
added a commit
that referenced
this issue
Dec 5, 2021
istreeter
added a commit
that referenced
this issue
Dec 6, 2021
istreeter
added a commit
that referenced
this issue
Dec 6, 2021
istreeter
added a commit
that referenced
this issue
Dec 6, 2021
istreeter
added a commit
that referenced
this issue
Dec 6, 2021
istreeter
added a commit
that referenced
this issue
Jan 10, 2022
istreeter
added a commit
that referenced
this issue
Jan 11, 2022
istreeter
added a commit
that referenced
this issue
Jan 20, 2022
istreeter
added a commit
that referenced
this issue
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
KinesisSInk
we have:This log message doesn't belong in the
KinesisSink
class. Because theKinesisSink
receives the thread pool in its constructor - it never creates a thread pool. The thread pool is created inKinesisCollector
.#124 (comment)
The text was updated successfully, but these errors were encountered: