Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logging of thread pool creation out of KinesisSink #129

Closed
dilyand opened this issue Mar 18, 2021 · 1 comment
Closed

Move logging of thread pool creation out of KinesisSink #129

dilyand opened this issue Mar 18, 2021 · 1 comment
Milestone

Comments

@dilyand
Copy link
Contributor

dilyand commented Mar 18, 2021

In KinesisSInk we have:

log.info("Creating thread pool of size " + kinesisConfig.threadPoolSize)

This log message doesn't belong in the KinesisSink class. Because the KinesisSink receives the thread pool in its constructor - it never creates a thread pool. The thread pool is created in KinesisCollector.

#124 (comment)

@dilyand dilyand mentioned this issue Mar 18, 2021
@dilyand dilyand modified the milestone: 2.3.0 Apr 27, 2021
@dilyand
Copy link
Contributor Author

dilyand commented Apr 29, 2021

log is a member of the Sink trait, which the KinesisSink extends. Thus, this logging must be done inside the sink instance, or else new logging needs to be added (using a separate logger).

@istreeter istreeter added this to the 2.5.0 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants