Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for env config #233

Open
colmsnowplow opened this issue Oct 20, 2022 · 0 comments
Open

Remove support for env config #233

colmsnowplow opened this issue Oct 20, 2022 · 0 comments

Comments

@colmsnowplow
Copy link
Collaborator

Originally, we developed this app with the requirement that a config-file-free configuration must be possible (due to some of the deployment modes we began with).

This is no longer a requirement, and facilitating it adds more to maintenance overhead than one would expect - we must maintain code for two separate hcl decoders, for example.

Since HCL configs can support env vars, there's no reason to continue supporting the old env var configuration model. We should rip that support out and use the opportunity to rationalise the config code as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant