Is it possible to set string length through source_options.columns configuration?

[isaacrlee]

Similar to decimal with decimal(<precision>, <scale>) is it possible to set length for string types in configuration e.g. string(16)?

Reading the source code here, I see the max length gets parsed but I haven't had luck getting the length to actually be set.

[flarco]

Yes, this was the idea at first. Using this mapping, looking at the string type (line 11), the mapped value used to be varchar() instead of varchar(65500) / varchar(max), where sling would fill the () will a number, but it ended up causing issues, so the max number was set. I'll need to take another stab at it.

[flarco]

@isaacrlee I pushed some changes for this. Do you mind testing on your local machine? The README has build instructions. Just need go installed.
use branch from #344

[isaacrlee]

@flarco Thanks for implementing this so quickly. I tried out #344 and read through the code.

I'm still not seeing the max length set but that might be because of my specific case; I'm trying to replicate from Snowflake to SQL Server. Is there a reason Snowflake isn't included with the changes (seeing it doesn't have varchar() here)?

Using target_options.table_ddl did work at the cost of having to set every column type, so that's a possible a workaround.

Also, unrelated to this discussion but in my testing of #344 the table_keys.index feature for #342 and #226 worked great!

[flarco]

Ok, pushed changes, should be good now.

[isaacrlee]

@flarco Just tested the changes and it works for the Snowflake source case now, thanks!