Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better API spec in Swagger UI #664

Open
thiennn opened this issue Nov 19, 2018 · 5 comments
Open

Better API spec in Swagger UI #664

thiennn opened this issue Nov 19, 2018 · 5 comments

Comments

@thiennn
Copy link
Contributor

thiennn commented Nov 19, 2018

We have added Swashbuckle to generate specs for SimplCommerce APIs #662. You can now see the generated spec in /swagger. The next step is enhance the APIs spec

@justindongqiang
Copy link
Contributor

I’d like to work with this.

@justindongqiang
Copy link
Contributor

@thiennn Trying to add the xml comment which generates the xml document displaying in swagger UI, but it does not seem to create the xml doc from xml comments.

@thiennn
Copy link
Contributor Author

thiennn commented Dec 3, 2018

Many controllers actions are returning anonymous types, I think we convert to explicit type first to leverage ActionResult.

About the xml doc, we can do it later

@thiennn thiennn pinned this issue Nov 16, 2019
thiennn added a commit that referenced this issue Nov 16, 2019
@tavershimafx
Copy link
Contributor

Many controllers actions are returning anonymous types, I think we convert to explicit type first to leverage ActionResult.

If I may ask, why are the controllers returning anonymous types instead of strongly typed objects?

@thiennn
Copy link
Contributor Author

thiennn commented Jun 23, 2020

Yes, it should return strongly typed. In the early days I return anonymous for faster coding. Now it should be refactored

bruslega added a commit to elsashop/SimplCommerce that referenced this issue Aug 22, 2023
bruslega pushed a commit to elsashop/SimplCommerce that referenced this issue Aug 22, 2023
bruslega added a commit to elsashop/SimplCommerce that referenced this issue Aug 22, 2023
bruslega added a commit to elsashop/SimplCommerce that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants