Skip to content

Commit

Permalink
Added fsyncEnabled option to values.yaml (#1425)
Browse files Browse the repository at this point in the history
  • Loading branch information
sbylica-splunk authored Sep 6, 2024
1 parent a185657 commit b7b3246
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .chloggen/addfsyncflagconfig.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: agent
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Added `fsyncFlag` configuration to allow users to enable fsync on the filestorage.
# One or more tracking issues related to the change
issues: [1425]
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@ extensions:
{{- if and (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq .Values.logsEngine "otel") }}
file_storage:
directory: {{ .Values.logsCollection.checkpointPath }}
{{- if not (eq (toString .Values.splunkPlatform.fsyncEnabled) "<nil>") }}
fsync: {{ .Values.splunkPlatform.fsyncEnabled }}
{{- end }}
{{- end }}

{{- if .Values.splunkPlatform.sendingQueue.persistentQueue.enabled }}
file_storage/persistent_queue:
directory: {{ .Values.splunkPlatform.sendingQueue.persistentQueue.storagePath }}/agent
timeout: 0
{{- if not (eq (toString .Values.splunkPlatform.fsyncEnabled) "<nil>") }}
fsync: {{ .Values.splunkPlatform.fsyncEnabled }}
{{- end }}
{{- end }}


Expand Down
3 changes: 3 additions & 0 deletions helm-charts/splunk-otel-collector/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@
}
}
}
},
"fsyncEnabled": {
"type": "boolean"
}
},
"anyOf": [
Expand Down
5 changes: 5 additions & 0 deletions helm-charts/splunk-otel-collector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ splunkPlatform:
enabled: false
storagePath: "/var/addon/splunk/exporter_queue"

# Option to set fsync value for filestorage extension used by the agent. Enabling this option will ensure
# database integrity at the cost of performance. If not set it will use default value for this extension.
# Refer to: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/storage/filestorage#file-storage
# fsyncEnabled: true

################################################################################
# Splunk Observability configuration
################################################################################
Expand Down

0 comments on commit b7b3246

Please sign in to comment.