Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text to the new share image (Android-only) #250

Open
1 of 2 tasks
jamespearson opened this issue Oct 3, 2019 · 5 comments
Open
1 of 2 tasks

Add text to the new share image (Android-only) #250

jamespearson opened this issue Oct 3, 2019 · 5 comments
Labels
F-planned New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed

Comments

@jamespearson
Copy link
Contributor

jamespearson commented Oct 3, 2019 •
edited by amaury1093
Loading

In #242 I added a new Share image on iOS. It would be nice if it shared the old text and the image (if possible)
@amaury1093 amaury1093 changed the title Add test to the new share image Add text to the new share image Oct 3, 2019
@amaury1093 amaury1093 added F-planned New feature or request Hacktoberfest help wanted Extra attention is needed labels Oct 3, 2019
DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Oct 6, 2019
@DragonSpirit
feat: Share android image via expo-sharing (shootismoke#250)
d85c44d
DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Oct 6, 2019
@DragonSpirit
feat: Share android image via expo-sharing (shootismoke#250)
fd94b0b 
(cherry picked from commit d85c44d)
DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Oct 6, 2019
@DragonSpirit
feat: Share android image via expo-sharing (shootismoke#250)
9371fcc
DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Oct 6, 2019
@DragonSpirit
feat: Share android image via expo-sharing (shootismoke#250)
e689b55
@DragonSpirit
Copy link
Contributor

Wow, missclick and link to this issue. 🌚
Can do this too, anyway I'm already deep into sharing field

@amaury1093
Copy link
Member

Sure! You can do this is the same PR, or in 2 separate PRs, as you wish.

@DragonSpirit
Copy link
Contributor

I prefer separate PR after reviewing #255

@DragonSpirit
Copy link
Contributor

DragonSpirit commented Oct 10, 2019 •
edited
Loading

@jamespearson does it should look like this?

@amaury1093
Copy link
Member

@DragonSpirit Yes, exactly! That looks really nice.

I would appreciate a PR on that. Also, if it works for Android too, then that's perfect.

DragonSpirit added a commit to DragonSpirit/shoot-i-smoke that referenced this issue Oct 12, 2019
@DragonSpirit
feat: Expand share dialog on iOS (shootismoke#250)
07e03e7
@DragonSpirit DragonSpirit mentioned this issue Oct 12, 2019
Merged
amaury1093 pushed a commit that referenced this issue Oct 16, 2019
@DragonSpirit @amaury1093
feat: Expand share dialog on iOS (#250) (#278)
0a37241 
* feat: Expand share dialog on iOS (#250)

* update codestyle
@amaury1093 amaury1093 changed the title Add text to the new share image Add text to the new share image (Android-only) Oct 17, 2019
amaury1093 pushed a commit that referenced this issue Dec 29, 2019
@DragonSpirit @amaury1093
fix: Fix android statusbar translucency (#374)
79f3345 
* feat: Expand share dialog on iOS (#250)

* update codestyle

* #321 - Fix android statusbar translucency

* Update barStyle
@amaury1093 amaury1093 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F-planned New feature or request Hacktoberfest https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamespearson @DragonSpirit @amaury1093