Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove doctrine-specification package #1921

Open
acelaya opened this issue Nov 17, 2023 · 2 comments
Open

Remove doctrine-specification package #1921

acelaya opened this issue Nov 17, 2023 · 2 comments

Comments

@acelaya
Copy link
Member

acelaya commented Nov 17, 2023

The package has served the project well, and it was important to make API restrictions a reality.

However, it is mostly stale. They haven't released a new version, created an issue or committed in more than 2 years.

With the upcoming Symfony 7 and Doctrine ORM 3, this package is going to become a blocker to update.

Removing it seems the most sensible and future-proof option, but it's not going to be an easy task.

API and database tests will come handy here.

@acelaya acelaya added this to the 4.0.0 milestone Nov 17, 2023
@acelaya
Copy link
Member Author

acelaya commented Nov 22, 2023

Short term, and to avoid blocking updates to latest Symfony and Dcotrine versions, it would be ok to fork the doctrine-specification repo, update dependencies, check CI passes, then republish as shlinkio/doctrine-specification.

That would give time to migrate away from the library progressively.

@acelaya acelaya moved this to Todo in Shlink Feb 1, 2024
@acelaya acelaya removed this from the 4.0.0 milestone Feb 17, 2024
@acelaya acelaya removed the status in Shlink Feb 17, 2024
@acelaya
Copy link
Member Author

acelaya commented Feb 17, 2024

For now, the package has been forked in https://github.com/shlinkio/doctrine-Specification, adding support for Doctrine ORM 3.0, Symfony 7.0 and PHP 8.2/83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant