Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping class dimensions are not determined correctly #198

Open
luzat opened this issue Mar 29, 2021 · 0 comments
Open

Shipping class dimensions are not determined correctly #198

luzat opened this issue Mar 29, 2021 · 0 comments

Comments

@luzat
Copy link

luzat commented Mar 29, 2021

In WC_Shipcloud_Shipping::get_shipping_class_dimensions the following line fails to find the requested taxonomy:

$taxonomy = get_term_by( 'name', $shipping_class, 'product_shipping_class' );

The issue is, that $shipping_class is a slug, not the readable name. The line should be changed to:

$taxonomy = get_term_by( 'slug', $shipping_class, 'product_shipping_class' );

Otherwise no shipping class dimensions will be read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant