-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
35 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
## Contributions | ||
|
||
This project is open for contributions. All contributions must adhere to the [Airbnb Javascript](http://airbnb.io/javascript/) style guide. | ||
|
||
#### To get started: | ||
1. Create a feature branch for any issue you want to resolve | ||
|
||
2. Implement the said feature | ||
|
||
4. Commit your changes | ||
> Your commit message(s) should follow the format below. It should comprise of: | ||
> * A header: summarizes what feature was implemented | ||
>* A body: gives a concise description of said feature | ||
> ``` | ||
> feat(kafka): implement exactly one time delivery | ||
> - ensure every event published to kafka is delivered exactly once | ||
> - implement error handling for failed delivery | ||
4. Raise a pull request to the `develop` branch | ||
> Pull requests should also follow the format below: | ||
> ``` | ||
> - What does this PR do? | ||
> - Description of Task to be completed? | ||
> - How should this be manually tested? | ||
> - Any background context you want to provide? | ||
> - Screenshots (if appropriate) | ||
> - Questions | ||
5. Once your pull request has been reviewed and any possible feedback addressed, your work will be merged. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0807fa9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the db migration please add the --url " " to the command
sequelize db:migrate --url 'postgres://user:password@localhost:5432/bookgalle
ry'
0807fa9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jenniekibiri, adding the DB URL to the sequelize command is not necessary.
If you add the URL to your local
.env
file as specified in theREADME
file, sequelize will pick the URL up. A sample.env.sample
was provided as a guide of what your.env
should look like0807fa9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.