Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for React 17 #1097

Merged
merged 3 commits into from
Nov 28, 2024
+16 −5
Merged

Drop support for React 17 #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e80249b
Drop support for react 17
askoufis Nov 25, 2024
90ee2ae
Replace `hydrate` with `hydrateRoot` in `sku-with-https` fixture
askoufis Nov 28, 2024
de42380
Merge branch 'v14' into drop-react-17-support
askoufis Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/tough-toys-beg.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'sku': major
---

Drop support for React 17.x

**BREAKING CHANGE**

React 17 is no longer supported. Consumers will need to upgrade to React 18. Consumers still on v17 should follow the [How to Upgrade to React 18 guide]. Additionally, ensure any dependencies that rely on React are compatible with React 18.

[How to Upgrade to React 18 guide]: https://react.dev/blog/2022/03/08/react-18-upgrade-guide
4 changes: 2 additions & 2 deletions fixtures/sku-with-https/src/serverClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { hydrate } from 'react-dom';
import { hydrateRoot } from 'react-dom';
import { loadableReady } from 'sku/@loadable/component';

import App from './App';

loadableReady(() => {
hydrate(<App />, document.getElementById('app'));
hydrateRoot(document.getElementById('app'), <App />);
});
6 changes: 3 additions & 3 deletions packages/sku/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
"homepage": "https://github.com/seek-oss/sku#readme",
"peerDependencies": {
"@storybook/react-webpack5": "^7.0.0 || ^8.0.0",
"@types/react": "^17.0.0 || ^18.0.0",
"react": "^17.0.0 || ^18.0.0",
"react-dom": "^17.0.0 || ^18.0.0"
"@types/react": "^18.0.0",
"react": "^18.0.0",
"react-dom": "^18.0.0"
},
"peerDependenciesMeta": {
"@storybook/react-webpack5": {
Expand Down