Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise select element required styling #57

Open
scottaohara opened this issue Jan 22, 2019 · 2 comments
Open

Revise select element required styling #57

scottaohara opened this issue Jan 22, 2019 · 2 comments
Labels
enhancement Help Wanted It'd be nice to get some other ideas/perspectives here.
Milestone

Comments

@scottaohara
Copy link
Owner

Today some initial styling and documentation were added for single select elements, using the required attribute and :invalid CSS.

The styling defaults the invalid Select element to appear red on page load. This should be better handled to only change state after use initiated invalid state, and not rely on color alone

@scottaohara scottaohara added this to the v2 release milestone Jan 22, 2019
@scottaohara scottaohara added the Help Wanted It'd be nice to get some other ideas/perspectives here. label Jan 25, 2019
@scottaohara scottaohara modified the milestones: Version 2, Version 3 Jul 8, 2019
@a11ycob
Copy link

a11ycob commented Jul 30, 2019

Scott, a question regarding the error messaging, currently styled as a tooltip. I've noticed that the tooltips themselves are not anchored to the offending select element, and if one were to inadvertently scroll it might appear as if the error message was part of another field. This might be something you wish to look at.

@scottaohara
Copy link
Owner Author

Hey @a11ycob

those are browser tooltips that firefox/chrome (not safari, didn't test ie) show if the required attribute is on a select. the scroll behavior is just how native tooltips work.

Looks like if you add a title="" to the select it will negate the native tooltip that the browser injects in there. It's interesting because VoiceOver doesn't announce it anyway, so from just a VO+Chrome test, seems there'd be no downside to doing that, other than removing the visual cue for sighted mouse users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Help Wanted It'd be nice to get some other ideas/perspectives here.
Projects
None yet
Development

No branches or pull requests

2 participants