Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage the library authors to publish an Ivy distribution #194

Open
3 of 5 tasks
cloakedch opened this issue Nov 22, 2021 · 3 comments
Open
3 of 5 tasks

Encourage the library authors to publish an Ivy distribution #194

cloakedch opened this issue Nov 22, 2021 · 3 comments

Comments

@cloakedch
Copy link

cloakedch commented Nov 22, 2021

  • I have searched for similar issues in this repository, but couldn't find one.
  • I have read the README and have a basic understanding how angular works.

I'm submitting a...

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report  
  • Feature request

Current behavior

As the title suggests, recent angular builds show the following warning when building:

Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
- ngx-mqtt [es2015/esm2015] (https://github.com/sclausen/ngx-mqtt.git)
Encourage the library authors to publish an Ivy distribution

Expected behavior

Unsure. I guess, ideally, an ivy-compatible build is generated?

Minimal working example of the problem with instructions

n/a

What is the motivation / use case for changing the behavior?

Warning shown by angular build.

Environment


ngx-mqtt version: 9.0.5


- Broker 
Irrelevant

Others:

Angular 13.0.3
npm 8.1.4
@ebosveld
Copy link

I would second this. For some reason the combination Angular 13, Jest and ngx-mqtt breaks our tests. I think it's because this is still a view engine library.

It still works in runtime, so it's some sort of combination of the three. If I run npx ngcc before I run ng test, it does work.

Unexpected value 'MqttModule' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.

Reproducable example repo:
https://github.com/ebosveld/ngx-mqtt-bug-with-angular-13

@konstantinschuette
Copy link

I would second this. For some reason the combination Angular 13, Jest and ngx-mqtt breaks our tests. I think it's because this is still a view engine library.

It still works in runtime, so it's some sort of combination of the three. If I run npx ngcc before I run ng test, it does work.

Unexpected value 'MqttModule' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.

Reproducable example repo: https://github.com/ebosveld/ngx-mqtt-bug-with-angular-13

Thats also happening on our side, after updating to Angular 13.
@sclausen Do you have any plans on fixing this?

@sclausen
Copy link
Owner

Unfortunately my current workload enforces me to tighten my priority list and since this is an unpaid side project of mine, I don't think I will have enough spare time for this in the near future. Things might relax a bit, but I wouldn't count on free support for this library soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants