Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#23 The Redis Password Index Added In RedisConfig #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#23 The Redis Password Index Added In RedisConfig #24

wants to merge 1 commit into from

Conversation

ankithg03
Copy link

@ankithg03 ankithg03 commented Nov 29, 2020 •
edited by carinadues
Loading

Fixes scandipwa/scandipwa#4132

#23 The Redis Password Index Added In RedisConfig

@ByJacob
Copy link

ByJacob commented Jan 19, 2022

@carinadues Now we cannot use redis with password without this PR :)

@carinadues carinadues mentioned this pull request Jan 19, 2022
Open
@carinadues
Copy link
Contributor

carinadues commented Jan 19, 2022 •
edited
Loading

Hello! We'll add it to the milestone 5.2.5
cc: @ByJacob

riha112
riha112 requested changes Feb 9, 2022
View reviewed changes
Copy link

@riha112 riha112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If password for Redis is not set will throw exception due to inaccessible array index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riha112 riha112 riha112 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use redis with password
4 participants
@ankithg03 @ByJacob @carinadues @riha112