Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

ESLint plugin in webpack does not respect workspace's configuration #46

Open
yeegor opened this issue Mar 29, 2021 · 0 comments
Open

ESLint plugin in webpack does not respect workspace's configuration #46

yeegor opened this issue Mar 29, 2021 · 0 comments

Comments

@yeegor
Copy link
Contributor

yeegor commented Mar 29, 2021

Describe the bug

If ESLint in package.json is switched off (removed at all) - webpack still throws on ESLint rule violations.

Did you try recovering your dependencies?

This is a fresh CSA installation of 29.03.2021
Ergo, nothing to recover. This should work by default.

Which terms did you search for in User Guide?

Searching for "ESLint" on docs.scandipwa.com gave me a solution - put "ignorePatterns": ["src/**"] inside of ESLint configuration. This is a valid solution, although not intuitive. When I remove ESLint from the configuration at all, I expect it not to be in the application during the compilation, just as it becomes absent in my code editor.

Environment

macOS Big Sur 11.2.3
node 14.16.0
yarn 1.22.10

Steps to reproduce

  1. npx create-scandipwa-app --template blank <name>
  2. Violate some eslint rules of the @scandipwa config. See errors highlighted in your code editor.
  3. Remove the eslint field from the generated package.json file. See no errors that previously have been highlighted.
  4. Launch the project. See compilation errors of following format

image

Expected behavior

ESLint-related compilation errors do not arise when ESLint is switched off for the project.

Actual behavior

ESLint-related compilation errors arise.

Reproducible demo

Fresh CSA installation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant