Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Namespaces for arrow functions are generated non-exclusively #15

Open
alfredsgenkins opened this issue Jan 25, 2021 · 2 comments
Open

Comments

@alfredsgenkins
Copy link
Contributor

Describe the bug

The namespace generated for arrow functions of then handler do not generate namespaces correctly.

image

@yeegor
Copy link
Contributor

yeegor commented Feb 2, 2021

I can propose several solutions to this issue:

  1. Less backwards-compatible, more straightforward
    image

  2. More backwards-compatible, less straightforward
    image

Since we don't have many plugins for v4 now, we can allow breaking changes to some extent. What do you think?

@alfredsgenkins
Copy link
Contributor Author

I prefer first option, while the question is what is that all keyword appearing in the code? Are there other potentially breaking cases, except then? Probably, there are. In that case, maybe we should add one, two, etc. (or first, second, ...) (or 1, 2, ...) to arguments? Otherwise we must handle each case separately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants