Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded usage of Bash #131

Open
Mr0Bread opened this issue Jun 22, 2023 · 2 comments
Open

Hardcoded usage of Bash #131

Mr0Bread opened this issue Jun 22, 2023 · 2 comments

Comments

@Mr0Bread
Copy link

Describe the bug

CMA always relies on bash shell to spawn subprocesses. Such approach does not consider systems where bash is not installed and blocks installation
image

Environment

OS: MacOS Ventura
Package version: 1.16.1

Steps to reproduce

(Write your steps here:)

  1. Run npm run start on MacOS where bash is not present

Expected behavior

CMA should use default shell of system

Actual behavior

Installation fails since CMA can't use bash
image
@ejnshtein
Copy link
Collaborator

bash is used because it can run any command that is given to it via the -c argument, it simplifies the execution of commands on the system.
During development I wasn't able to find similar feature in zsh so we went with bash till the end.
If you have a proposal for this, or you know how to execute zsh with given command, this will be great!

Will look more into it, but I can't promise anything right now 🫡

@Mr0Bread
Copy link
Author

Have you tried: https://github.com/sindresorhus/execa ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejnshtein @Mr0Bread