Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3.3.3, 2.13.13, 2.12.19 #660

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Sep 3, 2024

I didn't go to 2.13.14 because I'd have to upgrade Scala.js as well and we seek to avoid doing that in this repo unless we must, for maximum compatibility

going from Scala 3.2 to 3.3 might seem inconsistent with that, but I think we should do it, because all of the messaging around Scala 3 has been super consistent that 3.3 is the first LTS version and older versions are dead. besides, 3.3 isn't at all new anymore.

I didn't go to 2.13.14 because I'd have to upgrade Scala.js as
well and we seek to avoid doing that in this repo unless we
must, for maximum compatibility

going from Scala 3.2 to 3.3 might seem inconsistent with that,
but I think we should do it, because all of the messaging around
Scala 3 has been super consistent that 3.3 is the first LTS and
older versions are dead. plus 3.3 isn't at all new anymore.
@SethTisue SethTisue self-assigned this Sep 3, 2024
This was referenced Sep 3, 2024
@SethTisue SethTisue removed their assignment Sep 3, 2024
@manuzhang
Copy link

Thanks @SethTisue. Do we have plan to make a new release after this update?

@SethTisue
Copy link
Member Author

Nothing substantive has been merged since 2.12.0, so I don't see a reason to.

@SethTisue
Copy link
Member Author

Oh, there's #658. We could release after that one.

@SethTisue SethTisue merged commit 3fe1cb0 into scala:main Sep 7, 2024
23 checks passed
@SethTisue SethTisue deleted the scala-bumps branch September 7, 2024 08:26
@manuzhang
Copy link

Thanks @SethTisue. Since JDK 21 support is added into 2.12.18, this upgrade (and next release) really helps downstream projects to simplify Scala dependencies.

@SethTisue
Copy link
Member Author

SethTisue commented Sep 10, 2024

hmm, but I don’t think it does; it doesn’t matter in the slightest to downstream users whether we upgraded our Scala version here or not

I think you may have incorrect ideas about how these things work.

@manuzhang
Copy link

Do you mean we shouldn't pull in Scala dependencies from this project?

@SethTisue
Copy link
Member Author

@manuzhang I don't understand your question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants