You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suppose that in some cases 'early-semver-<major/minor/patch>' are wrongly added to the PRs produced by scala-steward
Currently there is a code below to define the severity of change for early-semver. Judging by the definition I would say it should return None if major is not zero which in turn will lead to earlySemVerLabel not having 'early-semver-<major/minor/patch>' for dependency changes with major > 0
I have found that even in your test the lable is wrongly added for the following dependency changes
val update1 = ("ch.qos.logback".g % "logback-classic".a % "1.2.0" %> "1.2.3").single
val update2 = ("com.example".g % "foo".a % "1.0.0" %> "2.0.0").single
val update = Update.Grouped("my-group", None, List(update1, update2))
val earlySemVerLabel = semVerVersions.flatMap { case (curr, next) =>
SemVer.getChangeEarly(curr, next).map(c => s"early-semver-${c.render}")
}
@tailrec
def getChangeEarly(from: SemVer, to: SemVer): Option[Change] = {
val zero = "0"
// Codacy doesn't allow using `if`s, so using `match` instead
(from.major === zero, to.major === zero) match { // work around Codacy's "Consider using case matching instead of else if blocks"
case (true, true)
if from.minor =!= zero ||
to.minor =!= zero ||
from.patch =!= zero ||
to.patch =!= zero =>
getChangeEarly(
from.copy(major = from.minor, minor = from.patch, patch = zero),
to.copy(major = to.minor, minor = to.patch, patch = zero)
)
case _ =>
getChangeSpec(from, to)
}
}
The text was updated successfully, but these errors were encountered:
I suppose that in some cases 'early-semver-<major/minor/patch>' are wrongly added to the PRs produced by scala-steward
Currently there is a code below to define the severity of change for early-semver. Judging by the definition I would say it should return None if major is not zero which in turn will lead to earlySemVerLabel not having 'early-semver-<major/minor/patch>' for dependency changes with major > 0
I have found that even in your test the lable is wrongly added for the following dependency changes
The text was updated successfully, but these errors were encountered: