Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some of the verbose PR description instructions into PR comments #3114

Open
lihaoyi opened this issue Jul 9, 2023 · 3 comments
Open

Comments

@lihaoyi
Copy link

lihaoyi commented Jul 9, 2023

Currently, the verbose PR descriptions end up in the commit history by anyone using Squash and Merge on Github, which is a relatively common workflow for those wanting to maintain linear histories:

Screenshot 2023-07-09 at 10 32 47 AM

To avoid this, we can move the bulk of the instructions/about/FAQ/etc. in a PR comment, leaving only the core Scala Stweward: update foo bar from v1 to v2 text in the PR description

@fthomas
Copy link
Member

fthomas commented Aug 1, 2023

I cannot reproduce this. For example, fthomas/status-page@dc7716b and scala-steward-org/test-repo-1@c4e334f have been "Squash and merge"-ed via GitHub and both do not contain the PR body.

@lihaoyi
Copy link
Author

lihaoyi commented Aug 1, 2023

@fthomas whether it contains the PR body or not is configurable in repo settings.

In my org, we put a lot more effort into reviewing at PR granularity rather than commit granularity, so the focus is on readable PR descriptions that are then squashed into the single commit description when merging. So we configure the repo to use the PR description as the message. This works great for almost all PRs, except for Scala Steward. And that can be fixed if Scala Steward were tweaked as described in this ticket

@lihaoyi lihaoyi closed this as completed Aug 1, 2023
@lihaoyi lihaoyi reopened this Aug 1, 2023
@lihaoyi
Copy link
Author

lihaoyi commented Aug 1, 2023

FYI here's the repo setting if you haven't seen it

Screenshot 2023-08-01 at 2 50 50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants