Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The complexes query reports stripped references incorrectly #214

Open
pokedthefrog opened this issue Jan 9, 2023 · 2 comments
Open

The complexes query reports stripped references incorrectly #214

pokedthefrog opened this issue Jan 9, 2023 · 2 comments
Assignees
Labels
bug Problem in the code

Comments

@pokedthefrog
Copy link

When calling omnipath.requests.Complexes.complex_genes(), the references column always reports stripped references which, in turn, results in the references_stripped column containing rubbish data. This seems to be a problem with the web service (see here) and also exists in pypath.

I am not sure if always reporting back stripped references for complexes is an intentional choice. Regardless, it is the following snippet that seems to break the references_stripped column:

https://github.com/saezlab/omnipath/blob/f48c3bb37c91ebf3cfd8261236c7770bcdab6cf2/omnipath/_core/requests/_utils.py#L151-L157

Changing the regex to something that ensures that the label does indeed exist seems to provide a temporary fix: (?=.*[a-zA-Z])[-\w]*:?(\d+). I understand, though, that this is a minor issue and making this change may unintentionally break something else.

Thanks a lot for the amazing package and your help! 😊

@deeenes deeenes self-assigned this Jan 9, 2023
@deeenes deeenes added the bug Problem in the code label Jan 9, 2023
@deeenes
Copy link
Member

deeenes commented Jan 9, 2023

Hi,

Thanks for reporting! The solution would be to make pypath include the resource names along the references, as in other query types. It will take some days -- or couple of weeks -- until this propagates to the web service though. I hope that's fine with you.

I might transfer this issue to pypath.

@deeenes deeenes transferred this issue from saezlab/omnipath Jan 9, 2023
@pokedthefrog
Copy link
Author

Of course it is— thanks a lot for the prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem in the code
Projects
None yet
Development

No branches or pull requests

2 participants