Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another fully set up bank to the seed. #4685

Open
2 tasks
cielf opened this issue Sep 30, 2024 · 10 comments · May be fixed by #4826
Open
2 tasks

Add another fully set up bank to the seed. #4685

cielf opened this issue Sep 30, 2024 · 10 comments · May be fixed by #4826

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 30, 2024

Summary

Add an additional fully set-up bank to the seed.

Why?

Useful for manual testing that reports, etc, that should be restricted to one bank's information, are.

Details

WE will want to add the bank, and a bank admin. Also a partner, with the accompanying user.

Contact info:
Name: Second City Essentials Bank
Contact email (will be email of admin): [email protected]

Partner info:
Name: Second City Senior Center
email: [email protected]

It'd be nice if it had a couple of unique items -- named something like "Second City Item [number]", just so it'll be clear if they are showing up where they shouldn't.
Set it up with a few donations, purchases, requests, and distributions. No need to go wild .

Criteria for completion

  • Bank and accompanying other records added to the seed.
  • Contributing.md documentation updated to include the signons.
@sbpipb
Copy link
Collaborator

sbpipb commented Oct 3, 2024

i can work on this one too

@sbpipb sbpipb self-assigned this Oct 3, 2024
Copy link
Contributor

github-actions bot commented Nov 3, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Nov 3, 2024
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Nov 11, 2024
@Benjamin-Couey
Copy link
Contributor

May I work on this one?

@cielf
Copy link
Collaborator Author

cielf commented Nov 22, 2024

Yes you may.

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Nov 22, 2024
@Benjamin-Couey
Copy link
Contributor

Mostly wrapping things up, but there are some points I'd like clarification on.

The new bank's admin having the [email protected] breaks with the current pattern of the other two banks just having numbered emails ([email protected], [email protected], etc.). I want to double check: is that's something we want to do?

There are a number of places in seed.rb where the Faker library is used to generate names, addresses, contact information, etc. However, there are also several places where the library isn't used and hand-written values are used. Is there a preference between the two? Should I be reworking seed.rb to always use one of these two methods?

@cielf
Copy link
Collaborator Author

cielf commented Nov 27, 2024

The current pattern is legacy, to be sure. I think having a reasonable connection between the login and the name of the bank works.

As for the other -- @dorner -- do your strong opinions around randomized test data extend to the seed?

@dorner
Copy link
Collaborator

dorner commented Nov 28, 2024

When it comes to seeds I don't really care much, because it's just for manual testing. If anything I think you'll have a more educated opinion than me :)

@cielf
Copy link
Collaborator Author

cielf commented Nov 29, 2024

(Nods) I don't see any need for rework vis-a-vis Faker vs hard-coded values. On a going forward basis, I would tend towards Faker rather than hard-coded, as better for demo purposes, but it's not a big deal.

@Benjamin-Couey
Copy link
Contributor

Gotcha, thank you both for the clarification.

@Benjamin-Couey Benjamin-Couey linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants