-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another fully set up bank to the seed. #4685
Comments
i can work on this one too |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
May I work on this one? |
Yes you may. |
Mostly wrapping things up, but there are some points I'd like clarification on. The new bank's admin having the [email protected] breaks with the current pattern of the other two banks just having numbered emails ([email protected], [email protected], etc.). I want to double check: is that's something we want to do? There are a number of places in |
The current pattern is legacy, to be sure. I think having a reasonable connection between the login and the name of the bank works. As for the other -- @dorner -- do your strong opinions around randomized test data extend to the seed? |
When it comes to seeds I don't really care much, because it's just for manual testing. If anything I think you'll have a more educated opinion than me :) |
(Nods) I don't see any need for rework vis-a-vis Faker vs hard-coded values. On a going forward basis, I would tend towards Faker rather than hard-coded, as better for demo purposes, but it's not a big deal. |
Gotcha, thank you both for the clarification. |
Summary
Add an additional fully set-up bank to the seed.
Why?
Useful for manual testing that reports, etc, that should be restricted to one bank's information, are.
Details
WE will want to add the bank, and a bank admin. Also a partner, with the accompanying user.
Contact info:
Name: Second City Essentials Bank
Contact email (will be email of admin): [email protected]
Partner info:
Name: Second City Senior Center
email: [email protected]
It'd be nice if it had a couple of unique items -- named something like "Second City Item [number]", just so it'll be clear if they are showing up where they shouldn't.
Set it up with a few donations, purchases, requests, and distributions. No need to go wild .
Criteria for completion
The text was updated successfully, but these errors were encountered: