Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Location on purchase and donation should default to the Default Intake Location #4436

Open
2 tasks
cielf opened this issue Jun 9, 2024 · 7 comments · May be fixed by #4722
Open
2 tasks

Storage Location on purchase and donation should default to the Default Intake Location #4436

cielf opened this issue Jun 9, 2024 · 7 comments · May be fixed by #4722
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 9, 2024

Summary

The storage location on purchases and donations should default to the Default Intake Location specified on the organization

Why

Saves bank time and possible mistakes - especially if the default is not the first in the drop down list.

Details

Recreation

While signed in as [email protected]
The default intake location is specified in: My organization | Edit (about half-way down the page).
The new donation screen can be reached via: Donations | New Donation
The new purchase screen can be reached via: Purchases | New Purchase

Both of these should be defaulted to the default intake location, if it has been specified. Otherwise, no default.

Criteria for completion

  • behaviour as described above
  • automated tests that confirm that behaviour
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jun 9, 2024
@PhilipDeFraties PhilipDeFraties self-assigned this Jun 14, 2024
@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Jun 14, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf cielf added Help Wanted Groomed + open to all! and removed stale labels Jul 22, 2024
@lenikadali
Copy link

Hello @cielf

I would like to work on this issue and wanted to clarify the expected behaviour:

when the user loads the form, the Default Intake Location that appears should be whatever value that is specified on the organization and then the user should manually select a different Storage Location where applicable.

Is this correct or is there a different interpretation of how this should behave?

Thanks in advance 🙏🏿

@cielf
Copy link
Collaborator Author

cielf commented Oct 14, 2024

That sounds right -- and that should happen on purchases and donations (note: the default rules for distribution storage location are different).

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Oct 14, 2024
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Nov 21, 2024

The PR is actively in the review cycle, so reassigning to @lenikadali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants