Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite add_analyzer script to C++ #125

Open
mikepurvis opened this issue Sep 19, 2019 · 0 comments
Open

Rewrite add_analyzer script to C++ #125

mikepurvis opened this issue Sep 19, 2019 · 0 comments

Comments

@mikepurvis
Copy link
Member

mikepurvis commented Sep 19, 2019

As part of our Python 3 migration, the add_analyzer script has come up as a nuisance which would be nice to avoid. Given that the rest of this package is C++, how would we feel about rewriting the script to be a small binary and parameterizing the service name?

The main proviso is that it would still need to shell out to rosparam path/to/my.yaml /namespace to perform the yaml loading, so the startup cost of running that Python program would be paid, but not the memory cost of a long-running Python process.

If there's interest in this, I can send a PR.


Memory size should probably not be a major consideration in this, but there is a slight savings— the python process at idle has a vsize of around 1MB, while the C++ version at idle is 400kb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant