Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-typescript supports tsconfigDefaults and tsconfigOverride #965

Closed
aladdin-add opened this issue Aug 4, 2021 · 3 comments
Closed

Comments

@aladdin-add
Copy link

aladdin-add commented Aug 4, 2021

  • Rollup Plugin Name: @rollup/plugin-typescript
  • Rollup Plugin Version: n/w

Feature Use Case

I am trying to move from rollup-plugin-typescript2 to @rollup/plugin-typescript in tsdx (weiran-zsd/dts-cli#2). it used the (tsconfigDefaults and tsconfigOverride](https://github.com/ezolenko/rollup-plugin-typescript2#plugin-options), while seems the official plugin does not support it.

Feature Proposal

support the two options as rollup-plugin-typescript2. :)

@ericmorand
Copy link

Why are you moving from a plugin that provides what you need to a plugin that doesn't?

@shellscape
Copy link
Collaborator

I'd recommend learning how to extend tsconfig.json based on need and for different build conditions. That will accomplish what those options accomplish for the other plugin. Given that this is built into TypeScript (https://www.typescriptlang.org/tsconfig#extends) we're going to decline adding these two options to the plugin.

@rollup rollup deleted a comment from ericmorand Aug 4, 2021
@rollup rollup locked and limited conversation to collaborators Aug 4, 2021
@shellscape
Copy link
Collaborator

We don't compare plugins here with others from the ecosystem. Plugins here may have different philosophies to those elsewhere in the greater Rollup community, and that's what makes our community solid. We're all on the same team, and comments that purport to pit one project against another, or compare negatively, are not welcome here.

As always, we encourage and welcome forks of the projects in this repo to accomplish things beyond what the maintainers here accept into the plugins in this repo. We're even happy to promote them by means of https://github.com/rollup/awesome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants