Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token and id usage, clear up documentation for token. #59

Closed
wants to merge 1 commit into from
Closed

Fix token and id usage, clear up documentation for token. #59

wants to merge 1 commit into from

Conversation

tedvdb
Copy link

@tedvdb tedvdb commented Oct 25, 2020 •
edited
Loading

Resolves #57
Resolves #48

@tedvdb tedvdb changed the title Fix token and id usage, clear up documentations for token. Fix token and id usage, clear up documentation for token. Oct 25, 2020
@ressof
Copy link

ressof commented Jan 14, 2021

Please merge this commit

@georgeh georgeh mentioned this pull request Apr 4, 2021
Open
ghost
ghost reviewed Jul 2, 2022
View reviewed changes
custom_components/samsungtv_custom/media_player.py
@@ -62,8 +62,8 @@
CONF_SOURCELIST = "sourcelist"
CONF_APPLIST = "applist"
CONF_PROTOCOL = "protocol"
CONF_ID = ""
CONF_TOKEN = ""
CONF_ID = "id"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make more sense to just use the imported constants instead of redefining them

@At-M At-M mentioned this pull request Aug 15, 2022
Open
@tedvdb tedvdb closed this by deleting the head repository May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Token Invalid config for [media_player.samsungtv_custom]: [token]
2 participants
@tedvdb @ressof