Fix hidden layer tile selection bug #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
riethmayer
reviewed
Nov 13, 2024
src/zustand/game-store.ts
Outdated
| const { gameBoard: board } = get(); | ||
| const { row, layer } = board[index]; | ||
| const currentTile = board[index]; | ||
| const { row, layer, column } = currentTile; |
riethmayer
reviewed
Nov 13, 2024
src/zustand/game-store.ts
Outdated
| board[j].layer === layer + 1 && | ||
| board[j].column === column; | ||
| }) | ||
| .map((j: string) => j); |
riethmayer
approved these changes
Nov 13, 2024
| }) | ||
| .map((j: string) => j); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| const isCoveringItem = (row: number, layer: number, column: number) => { | |
| const coveringItems = Object.keys(board); | |
| .filter((j) => { | |
| return board[j].row === row - 1 && | |
| board[j].layer === layer + 1 && | |
| board[j].column === column; | |
| }) | |
| return !!coveringItems && coveringItems[0] | |
| }; |
riethmayer
approved these changes
Nov 13, 2024
| @@ -159,6 +171,11 @@ export const useGameStore = create<GameState>()( | |||
| .map((i: string) => i); | |||
| }; | |||
|
|
|||
| // Check if covering tile exists | |||
| if (coveringItem(row, layer, column).length !== 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (coveringItem(row, layer, column).length !== 0) { | |
| if (isCoveringItem(row, layer, column)) { |
There was a problem hiding this comment.
Hehe so schlecht, nee geht nicht, dass man direkt ne andere Implementation suggested.
Wahrscheinlich auch um das discouragen.
riethmayer
approved these changes
Nov 13, 2024
| @@ -159,6 +171,11 @@ export const useGameStore = create<GameState>()( | |||
| .map((i: string) => i); | |||
| }; | |||
|
|
|||
| // Check if covering tile exists | |||
| if (coveringItem(row, layer, column).length !== 0) { | |||
There was a problem hiding this comment.
Hehe so schlecht, nee geht nicht, dass man direkt ne andere Implementation suggested.
Wahrscheinlich auch um das discouragen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue should be fixed without affecting any special tiles.