Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of declaration visibility #531

Open
RBusarow opened this issue Apr 11, 2022 · 0 comments
Open

better handling of declaration visibility #531

RBusarow opened this issue Apr 11, 2022 · 0 comments

Comments

@RBusarow
Copy link
Member

Currently, when parsing java or kotlin, declarations which are private, internal (kotlin), or "package private" (java) are filtered and not counted. protected declarations in either language are treated the same as public.

This quick-and-dirty approach seemed fine because ModuleCheck assumes that it's executing against a project which builds, which means that

  • declarations can't be ambiguous (no duplicates)
  • declarations can only be referenced if they're visible to the call site.

Unfortunately, declarations can be overloaded, packages can be shared across modules, and those overloaded declarations can be split across modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant