Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow images urls with trailing query string #126

Open
bashuss opened this issue Feb 25, 2024 · 1 comment
Open

Allow images urls with trailing query string #126

bashuss opened this issue Feb 25, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bashuss
Copy link

bashuss commented Feb 25, 2024

Is your feature request related to a problem? Please describe.
Image urls may not always end with .jpg, .png, ... as the urls may contain sizing and cropping information in a query string.
This of course only applies for images sourced on the web - is that supported? I can not get it to work (testing with current dev branch with localhost urls).

Describe the solution you'd like
Adjust the RegEx of the imageFactories, so a query string may follow.
Allow web images to be included in render.

Describe alternatives you've considered
An easy way for revisiting all images-urls after document parsing for adjustments to the paths.

Additional context
Add any other context or screenshots about the feature request here.

@richard-scryber richard-scryber self-assigned this Feb 26, 2024
@richard-scryber richard-scryber added the bug Something isn't working label Feb 26, 2024
@richard-scryber
Copy link
Owner

Hi Bernd, thank you for this. I think we had the same issue at a similar time as I have checked-in a change onto the sig-improvements branch. However I will migrate this to the main branch tomorrow and release as definitely a defect. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants