Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: bump ALL expired delegated roles no matter if they contain artifacts #476

Open
1 task done
MVrachev opened this issue Mar 26, 2024 · 0 comments
Open
1 task done

Comments

@MVrachev
Copy link
Member

MVrachev commented Mar 26, 2024

What is the task about?

Currently, when it's time to do an automatic bump of online roles the flow is:

  1. bump_online_roles
    2. _run_online_roles_bump
  2. self._update_snapshot with a list of target files that have expired

There in the execution of self._update_snapshot we call targets_crud.read_roles_joint_files which in return gives a list of joined records between RSTUF target roles and target files.
The problem is that if a bin does not have an artifact (target file) that is responsible for and it wouldn't be returned from targets_crud.read_roles_joint_files.

We should make sure that we bump ALL expired bins no matter if they contain artifacts.

To reproduce:

  1. make sure that only when you call bump_expiry from bootstrap that it will give the bins an expired date
    In all other cases of calling bump_expiry we want the function to behave as usual
  2. change the app.conf.beat_schedule in app.py to run online roles bump each minute so you don't have to wait
  3. run make run-dev
  4. add a few artifacts less than the total number of bins
  5. watch the logs and see that only bins that have targets will be updated

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant