Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: review & implement missing features of admin2 commands #533

Open
29 of 37 tasks
Tracked by #532
MVrachev opened this issue Mar 13, 2024 · 0 comments
Open
29 of 37 tasks
Tracked by #532

Task: review & implement missing features of admin2 commands #533

MVrachev opened this issue Mar 13, 2024 · 0 comments
Assignees

Comments

@MVrachev
Copy link
Member

MVrachev commented Mar 13, 2024

What is the task about?

Compare all missing features from admin2 commands that exist in our current corresponding commands.

This will be an umbrella issue for missing features for each of the commands.

Parent feature

#532

TODO

  • Sign command
  • Ceremony command
  • Metadata Update command
  • New command: rstuf admin send

Sign missing features

  • Get metadata that requires signature with API endpoint GET /api/v1/metadata/sign (check _get_pending_roles() from repository_service_tuf/cli/admin/metadata.py) -- @MVrachev :
  • Push new signatures for metadata to API endpoint POST /api/v1/metadata/sign (check send_payload from repository_service_tuf/helpers/api_client.py) -- @MVrachev:
  • Wait for the task to finish and report back to the CLI user (check task_status fromrepository_service_tuf/helpers/api_client.py) -- @MVrachev
  • Add an option to sign locally available files. Check
    def get_md_file(file_uri: str) -> Metadata:
    if it could be useful. - @MVrachev
  • Show key information from previous root keys even if they do not exist in new root for signing. - @KAUTH
  • Decide if in this command or another to implement rstuf admin metadata sign --delete used to delete/stop a DAS process. Should be replaced with something else. Maybe rstuf admin metadata sign stop or rstuf admin metadata sign delete. - @MVrachev - It should be rstuf admin metadata sign delete and select role from unsigned list if more than 1.
  • Add --dry-run mode.
  • Document different ways to operate the command.

Ceremony missing features

Metadata Update missing features

  • URI to trusted root
  • An api_server option.
  • Don't allow threshold < 2.
  • Send payload to the API server.
  • Check if we don't allow online key to be the same as root keys
  • Support DAS metadata update - @MVrachev
  • Make it mandatory to describe at least a threshold number of root keys. This means that it's not required to load their private keys, but only their public keys.
  • Add --dry-run mode.
  • Wait for the task to finish and report back to the CLI user (check task_status fromrepository_service_tuf/helpers/api_client.py)
  • Document different ways to operate the command.

New command: rstuf admin send

  • Add a new command rstuf admin bootstrap which can be used to upload a completed ceremony, sign or md update payload file.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MVrachev MVrachev changed the title Task: review missing features of admin2 commands Task: review & implement missing features of admin2 commands Mar 13, 2024
@MVrachev MVrachev self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants