Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Simplify the task result checks in CLI #508

Open
1 task done
Tracked by #537
kairoaraujo opened this issue Feb 9, 2024 · 0 comments
Open
1 task done
Tracked by #537

Task: Simplify the task result checks in CLI #508

kairoaraujo opened this issue Feb 9, 2024 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest Opt-in with this issue to Hacktoberfest and indicate you’re looking for contributions.

Comments

@kairoaraujo
Copy link
Member

What is the task about?

The RSTUF API has improved the Task state result since the release v0.10.0b1

On this release, it is no longer necessary to check the result[status] to verify the final state of the task as the ERRORED state was introduced.

The logic to check can be simplified.

https://github.com/repository-service-tuf/repository-service-tuf-cli/blob/605fcc582aa873a45615d637cfd2f12a1432b058/repository_service_tuf/helpers/api_client.py#L123_L159

Parent feature

No response

References

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Opt-in with this issue to Hacktoberfest and indicate you’re looking for contributions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kairoaraujo